Skip to content

Revert "Further improve JSX preserve output (#7445)" #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 16, 2025

Unfortunately, if the string contains escape sequences like \" for example, the result is not valid JSX if the string is not wrapped in braces. 😭

This reverts commit 8f9e0f1.

# Conflicts:
#	tests/tests/src/jsx_preserve_test.mjs
@cknitt cknitt requested a review from nojaf May 16, 2025 14:53
Copy link

pkg-pr-new bot commented May 16, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7475

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7475

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7475

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7475

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7475

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7475

commit: d1d0110

@cknitt cknitt requested a review from fhammerschmidt May 17, 2025 05:24
@cknitt cknitt merged commit 870906d into rescript-lang:master May 17, 2025
21 checks passed
@cknitt cknitt deleted the revert-jsx-improve branch May 17, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants